-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bring back OTEL receiver metrics #3917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! One small perf tweak and we're good.
// Int64Counter returns a Counter used to record int64 measurements that | ||
// produces no telemetry. | ||
func (Meter) Int64Counter(name string, _ ...metric.Int64CounterOption) (metric.Int64Counter, error) { | ||
return Int64Counter{Name: name}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the name is not one we care to track we should just return a NopInt64Counter
.
Just wondering will we get a patch to 2.5 soon or we need to wait until 2.6 is released for this fix? |
This will be released with 2.6. The release will likely occur towards the end of August |
Thanks. Then is there any suggestion/workaround on checking logs/metrics on refused spans while |
I would use: |
What this PR does:
This PR recovers the OTEL receiver metrics that Tempo previously exported.
The metrics stopped from being exported in this commit: #3148.
Doing a bit of code archeology here is where the OpenCensus code is removed open-telemetry/opentelemetry-collector#9102.
The way this works is by implementing a custom MeterProvider, adapted from go.opentelemetry.io/otel/metric/noop, to intercept the metrics emitted by obsreport.go and record them using our internal tooling.
Example of the metrics from the metrics endpoint:
Which issue(s) this PR fixes:
Fixes #3758
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]