Refactor clearCookies to return error

grafana · Aug 22, 2023 · 92db064 · 92db064
1 parent 0a83c65
commit 92db064
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/api/browser_context.go b/api/browser_context.go
@@ -9,7 +9,7 @@ type BrowserContext interface {
 	AddCookies(cookies goja.Value) error
 	AddInitScript(script goja.Value, arg goja.Value) error
 	Browser() Browser
-	ClearCookies()
+	ClearCookies() error
 	ClearPermissions()
 	Close()
 	Cookies() ([]any, error) // TODO: make it []Cookie later on

diff --git a/common/browser_context.go b/common/browser_context.go
@@ -479,15 +479,16 @@ func (b *BrowserContext) AddCookies(cookies goja.Value) error {
 }
 
 // ClearCookies clears cookies.
-func (b *BrowserContext) ClearCookies() {
+func (b *BrowserContext) ClearCookies() error {
 	b.logger.Debugf("BrowserContext:ClearCookies", "bctxid:%v", b.id)
 
 	clearCookies := storage.
 		ClearCookies().
 		WithBrowserContextID(b.id)
 	if err := clearCookies.Do(b.ctx); err != nil {
-		k6ext.Panic(b.ctx, "clearing cookies: %w", err)
+		return fmt.Errorf("clearing cookies: %w", err)
 	}
+	return nil
 }
 
 // Cookies is not implemented.