Skip to content

Commit

Permalink
Disable timeout on browser process execution
Browse files Browse the repository at this point in the history
This commit modifies the browser launching process to not pass a context
with timeout to the actual browser process cmd handle. Currently this
was done using as timeout the value set for the browser.timeout option,
which should serve a different purpose.
  • Loading branch information
ka3de committed May 2, 2023
1 parent 480c0c1 commit a03514c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chromium/browser_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ func (b *BrowserType) allocate(
flags map[string]any, env []string, dataDir *storage.Dir,
logger *log.Logger,
) (_ *common.BrowserProcess, rerr error) {
bProcCtx, bProcCtxCancel := context.WithTimeout(ctx, opts.Timeout)
bProcCtx, bProcCtxCancel := context.WithCancel(ctx)
defer func() {
if rerr != nil {
bProcCtxCancel()
Expand Down

0 comments on commit a03514c

Please sign in to comment.