Remove unimplemented JSHandle.getProperty API

grafana · Apr 22, 2024 · d6409e0 · d6409e0
1 parent 90a6853
commit d6409e0
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/browser/mapping.go b/browser/mapping.go
@@ -208,13 +208,6 @@ func mapJSHandle(vu moduleVU, jsh common.JSHandleAPI) mapping {
 			}
 			return dst, nil
 		},
-		"getProperty": func(propertyName string) *goja.Object {
-			var (
-				h = jsh.GetProperty(propertyName)
-				m = mapJSHandle(vu, h)
-			)
-			return rt.ToValue(m).ToObject(rt)
-		},
 		"jsonValue": jsh.JSONValue,
 	}
 }

diff --git a/common/js_handle.go b/common/js_handle.go
@@ -23,7 +23,6 @@ type JSHandleAPI interface {
 	Evaluate(pageFunc string, args ...any) any
 	EvaluateHandle(pageFunc string, args ...any) (JSHandleAPI, error)
 	GetProperties() (map[string]JSHandleAPI, error)
-	GetProperty(propertyName string) JSHandleAPI
 	JSONValue() (string, error)
 	ObjectID() cdpruntime.RemoteObjectID
 }
@@ -156,11 +155,6 @@ func (h *BaseJSHandle) getProperties() (map[string]jsHandle, error) {
 	return props, nil
 }
 
-// GetProperty retreves a single property of the JS handle.
-func (h *BaseJSHandle) GetProperty(_ string) JSHandleAPI {
-	return nil
-}
-
 // JSONValue returns a JSON version of this JS handle.
 func (h *BaseJSHandle) JSONValue() (string, error) {
 	remoteObject := h.remoteObject