Add a test to lock in behaviour for nav to iframe

This test actually tests that we can navigate to a page with iframes, click on a link, which navigates to another page with iframes. Once at the second page it will end the test and we can assert. Without the fix in the prior commit, this would panic on a deadlock. NOTE: This only works when we have headless mode on.
grafana · Jun 26, 2023 · f3e86e7 · f3e86e7
1 parent 7302034
commit f3e86e7
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 0 deletions.
diff --git a/tests/frame_test.go b/tests/frame_test.go
@@ -1,6 +1,7 @@
 package tests
 
 import (
+	"net/http"
 	"strconv"
 	"testing"
 
@@ -102,6 +103,42 @@ func TestFrameNoPanicWithEmbeddedIFrame(t *testing.T) {
 	assert.EqualValues(t, "Done!", result)
 }
 
+// Without the fix in https://github.com/grafana/xk6-browser/pull/942
+// this test would hang on the "sign in" link click.
+func TestFrameNoPanicNavigateAndClickOnPageWithIFrames(t *testing.T) {
+	t.Parallel()
+
+	if s, ok := env.Lookup(env.BrowserHeadless); ok {
+		if v, err := strconv.ParseBool(s); err == nil && v {
+			// We're skipping this when running in headless
+			// environments since the bug that the test fixes
+			// only surfaces when in headfull mode.
+			// Remove this skip once we have headfull mode in
+			// CI: https://github.com/grafana/xk6-browser/issues/678
+			t.Skip("skipped when in headless mode")
+		}
+	}
+
+	tb := newTestBrowser(
+		t,
+		withFileServer(),
+		withEnvLookup(env.ConstLookup(env.BrowserHeadless, "0")),
+	)
+	p := tb.NewPage(nil)
+	tb.withHandler("/iframeSignIn", func(w http.ResponseWriter, r *http.Request) {
+		http.Redirect(w, r, tb.staticURL("iframe_signin.html"), http.StatusMovedPermanently)
+	})
+
+	_, err := p.Goto(tb.staticURL("iframe_home.html"), nil)
+	require.NoError(t, err)
+
+	err = p.Click(`a[href="/iframeSignIn"]`, nil)
+	require.NoError(t, err)
+
+	result := p.TextContent("#doneDiv", nil)
+	assert.EqualValues(t, "Sign In Page", result)
+}
+
 func TestFrameTitle(t *testing.T) {
 	p := newTestBrowser(t).NewPage(nil)
 	p.SetContent(`<html><head><title>Some title</title></head></html>`, nil)

diff --git a/tests/static/iframe_home.html b/tests/static/iframe_home.html
@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<html lang="en">
+    <head></head>
+    <body>
+        <a href="/iframeSignIn">Sign In</a>
+        <iframe src="about:blank"></iframe>
+    </body>
+</html>
diff --git a/tests/static/iframe_signin.html b/tests/static/iframe_signin.html
@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<html lang="en">
+    <head></head>
+    <body>
+        <div id="doneDiv">Sign In Page</div>
+        <iframe src="about:blank"></iframe>
+    </body>
+</html>