Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the "remote persister" #1159

Closed
2 tasks done
ankur22 opened this issue Jan 16, 2024 · 0 comments
Closed
2 tasks done

Implement the "remote persister" #1159

ankur22 opened this issue Jan 16, 2024 · 0 comments
Assignees
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Jan 16, 2024

What?

Create a concrete type that satisfies the interface defined in #1155 that will enable the browser module to upload screenshots to a remote location.

Why?

To upload the screenshot data to the remote location that has been configured in the env var.

How?

This will involve a few steps:

  1. Use the two requests mechanism to perform the upload step:
    1. First request (which is authenticated) to retrieve one or more pre-signed urls.
      1. The module will need to keep track of the pre-signed urls and request more when it runs out of them.
    2. Use the given pre-signed urls for the uploading of the screenshot data.
  2. Implement the error handling when the requests are being rate limited. This could mean that we're not getting all the pre-signed urls that we've asked for or a 429 when trying to upload the screenshot.

Tasks

Tasks

Related PR(s)/Issue(s)

Prerequisite issue: #1155

@ankur22 ankur22 added team/k6browser To distinguish the issue on project boards. remote remote browser related labels Jan 16, 2024
@ankur22 ankur22 changed the title Use env vars to upload screenshot Implement the "remote persister" Jan 17, 2024
@ankur22 ankur22 self-assigned this Jan 29, 2024
@ankur22 ankur22 mentioned this issue Jan 30, 2024
3 tasks
@ankur22 ankur22 closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.
Projects
None yet
Development

No branches or pull requests

1 participant