Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up the local disk and remote persisters #1160

Closed
2 tasks done
ankur22 opened this issue Jan 16, 2024 · 0 comments
Closed
2 tasks done

Wire up the local disk and remote persisters #1160

ankur22 opened this issue Jan 16, 2024 · 0 comments
Assignees
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Jan 16, 2024

What?

Wire up the local disk persister (#1156) and remote persister (#1159) so that when the environment is setup correctly the remote persister is used otherwise the local persister is used.

Why?

When the configuration for the remote persister is present (the env var that was introduced in #1159), that implies that the screenshots are to be sent to a remote location. When that is not the case, then they need to be saved local to the disk.

How?

When the test run starts, if the env var (from #1159) is present and the remote persister is created, that is to be passed to the screenshotter. When this is not the case a local persister should be created and passed to the screenshotter.

  1. Read and parse K6_BROWSER_SCREENSHOTS_OUTPUT which should contain all the configuration required to upload the screenshot. Take a look at how it's done in k6 for traces.
  2. Create a new interface that works with both LocalPersister and RemotePersister which may require amendments to one of both of the concrete types.

Tasks

Tasks

Related PR(s)/Issue(s)

Prerequisite issues: #1156 & #1159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.
Projects
None yet
Development

No branches or pull requests

1 participant