You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactor the parsing of the option out of the promise and into the mapping layer for elementHandle.click.
Why
This will help avoid a scenario where more than one off main goja thread goroutine (i.e. promise) is ran concurrently which could try to access the goja runtime concurrently and cause a panic.
How
Move this to mapping layer. Should be a similar change to #1164.
The content you are editing has changed. Please copy your edits and refresh the page.
ankur22
changed the title
Fix elementHandle.click
Remove goja runtime value parsing from elementHandle.clickJan 19, 2024
ankur22
changed the title
Remove goja runtime value parsing from elementHandle.click
Refactor goja runtime value parsing out of elementHandle.clickJan 19, 2024
What
Refactor the parsing of the option out of the promise and into the mapping layer for
elementHandle.click
.Why
This will help avoid a scenario where more than one off main goja thread goroutine (i.e. promise) is ran concurrently which could try to access the goja runtime concurrently and cause a panic.
How
Move this to mapping layer. Should be a similar change to #1164.
Tasks
The text was updated successfully, but these errors were encountered: