Refactor locator.click parse #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
fix/locator-click-goja
branch
3 times, most recently
from
b1cbbf6
to
53a4d99
Compare
ka3de
previously approved these changes
Jan 19, 2024
This will be used by several of the click APIs to parse the options using the goja runtime before the core work is done async in a goroutine off the main event loop thread.
This avoids an issue with using the goja runtime within a promise outside of the main event loop thread, by moving the parsing of the option to the main event loop thread.
It's a lot clearer as to what is going on if the parse error in the mapping layer for locator.click is returned before the promise is initiated.
ankur22
force-pushed
the
fix/locator-click-goja
branch
from
eddc74e
to
0b11010
Compare
inancgumus
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor
locator.clickso that it parses the goja value using the goja runtime on the main goja thread and not in a new goroutine.Why?
This will avoid race issues since the goja runtime is not thread safe since it is a JS interpreter that is single threaded.
I've also confirmed that this API doesn't work with goja anywhere else, including when working with
eval, which is does since it usesnewPointerAction, which callswaitForSelector, that calls ,evalWithScriptand eventuallyeval, but sincereturnByValueisfalseit doesn't work with goja to transform the return value to a goja value.Checklist
Related PR(s)/Issue(s)
Updates: #1162