Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve empty browser string flag handling #1385

Closed
2 tasks done
inancgumus opened this issue Jun 13, 2024 · 0 comments
Closed
2 tasks done

Improve empty browser string flag handling #1385

inancgumus opened this issue Jun 13, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@inancgumus
Copy link
Member

inancgumus commented Jun 13, 2024

What?

In v1.5.1, passing a string flag without a value results in an invalid argument that ends with an equal sign. For example:

K6_BROWSER_ARGS=disable-site-isolation-trials

Produces the following argument that we pass while launching the browser:

disable-site-isolation-trials=

It should be:

disable-site-isolation-trials

Why?

Having a superfluous suffix (=) prevents browsers (e.g., Chrome) from interpreting the argument, making the argument defunct.

How?

Handle the argument correctly here.

Tasks

Tasks

  1. bug
    inancgumus

Related PR(s)/Issue(s)

No response

@inancgumus inancgumus added the bug Something isn't working label Jun 13, 2024
@inancgumus inancgumus self-assigned this Jun 13, 2024
@inancgumus inancgumus changed the title Improve valueless browser flag handling Improve empty browser string flag handling Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant