Fix browser empty string flag parsing #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, passing a flag that doesn't contain a value to K6_BROWSER_ARGS results in an argument with an equal sign suffix: K6_BROWSER_ARGS=disable-site-isolation-trials Results in: disable-site-isolation-trials= Instead of: disable-site-isolation-trials This PR fixes this problem.
inancgumus
force-pushed
the
fix/chrome-empty-string-flag-parsing
branch
from
c27f714
to
a6c0b99
Compare
ankur22
approved these changes
Jun 13, 2024
ankur22
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Correctly handles empty string flags that don't have a value.
Why?
See #1385.
Checklist
Related PR(s)/Issue(s)
Updates: #1385