Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the check on examples/fillform.js #1022

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Fix the check on examples/fillform.js #1022

merged 2 commits into from
Sep 1, 2023

Commits on Sep 1, 2023

  1. Fix the check on fillform 

    The check on the fillform example test worked but is not quite correct.
Check actually expects a function that returns a boolean, as is is
documented.
    @ankur22
    ankur22 committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    d155b3a View commit details
    Browse the repository at this point in the history

  2. Refactor page to p in check 

    This will help distinguish between page and the local variable in the
check.

Resolves: #1022 (comment)
Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
    @ankur22 @inancgumus
    ankur22 and inancgumus committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    0b5d155 View commit details
    Browse the repository at this point in the history