Fix propagation of page timeout

[ankur22]

What?

When working with the following APIs, the timeout was being set, but it wasn't then being propagated to the underlying frameManager and frames which meant that APIs the relied on the timeout were always working with the default 30 second timeout or the timeout set in the browserContext.

page.setDefaultTimeout()
page.setDefaultNavigationTimeout()

Why?

We want to be able to set the timeouts on the page and affect it's APIs, while also having a different timeout on its browserContext. This is the behaviour that we want, and at the moment the setting of timeouts through the page object does nothing.

Checklist

• I have performed a self-review of my code
• I have added tests for my changes
• I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Closes: #940

[inancgumus]

I've tested this with the following script, and it worked 🥳

Suggestion 1: Can you merge the (almost) duplicated test code for better maintainability? Suggestion: Run the same test with page and browserContext in the same test.

Suggestion 2: Should we update the fillform example with this timeout setting and a comment on top of it?

import { browser } from 'k6/x/browser';

export const options = {
  scenarios: {
    ui: {
      executor: 'per-vu-iterations',
      vus: 1,
      iterations: '1',
      options: {
        browser: {
            type: 'chromium',
        },
      },
    },
  }
};

export default async function() {
  const context = browser.newContext();
  context.setDefaultTimeout(1);
  const page = context.newPage();
  try {
    // page.setDefaultTimeout(1);
    await page.goto('https://test.k6.io', { waitUntil: 'networkidle' });
    page.waitForSelector("div[class$='overlay-box']");
  } finally {
    page.close();
  }
}

[ka3de]

LGTM.

[ankur22]

Suggestion 1: Can you merge the (almost) duplicated test code for better maintainability? Suggestion: Run the same test with page and browserContext in the same test.

I wanted to highlight that although they seem the same, they're in fact not the same. The tests for browserContext will have worked prior to the fix, whereas the tests for page only work after the fix. Happy to merge them though in a new PR once this and #1035 are merged in 👍

Suggestion 2: Should we update the fillform example with this timeout setting and a comment on top of it?

Happy to do this, just wondering what the hope is by doing that?

[inancgumus]

I wanted to highlight that although they seem the same, they're in fact not the same.

Ah, OK, makes sense 👍

Happy to do this, just wondering what the hope is by doing that?

I thought it might be helpful, but it's fine.

@ankur22