Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reupdate chrome not installed errs #1145

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

inancgumus
Copy link
Member

What?

Changes the Chrome/Chromium not installed error messages.

Why?

To make the errors clearer (applied as per @heitortsergent's request).

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #1136

@inancgumus inancgumus changed the title Change chrome not installed errs Reupdate chrome not installed errs Dec 21, 2023
Copy link

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the error message (and sorry I missed the first PR)! 🙇

Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@inancgumus inancgumus merged commit a224e27 into main Jan 8, 2024
17 checks passed
@inancgumus inancgumus deleted the update/chrome-not-found-err2 branch January 8, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants