Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parseConsoleRemoteObject to return error #1166

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Refactor parseConsoleRemoteObject to return error #1166

merged 2 commits into from
Jan 29, 2024

Commits on Jan 29, 2024

  1. Refactor parseConsoleRemoteObject to return error 

    There is another use case for parseConsoleRemoteObject, which is when
JSONValue is called. At the moment this API uses valueFromRemoteObject
which returns a goja.Value. Interestingly, the return value is always
converted to string before being returned to the caller, so the extra
step to convert to goja and then back to string is not needed.
    @ankur22
    ankur22 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    883820c View commit details
    Browse the repository at this point in the history

  2. Add unmarshalable value in error message

    @ankur22
    ankur22 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    5aedac1 View commit details
    Browse the repository at this point in the history