Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parsing of options for waitForEvent #1188

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Refactor parsing of options for waitForEvent #1188

merged 2 commits into from
Jan 25, 2024

Commits on Jan 23, 2024

  1. Move option parsing for waitForEvent 

    This change moves the option parsing out of the promise for
browserContext.waitForEvent. The change will help mitigate the risk of
accessing the (non thread safe) goja runtime by multiple goroutines
and instead force the parse (and working with the goja runtime) in the
main goja thread.
    @ankur22
    ankur22 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b126499 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Rename parsedOpts to popts to be consistent

    @ankur22
    ankur22 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f8decf7 View commit details
    Browse the repository at this point in the history