Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Goja from Execution Context Eval and from related parts #1189

Merged
merged 12 commits into from
Jan 25, 2024
Merged

Remove Goja from Execution Context Eval and from related parts #1189

merged 12 commits into from
Jan 25, 2024

Commits on Jan 25, 2024

  1. Refactor away from goja in execctx eval

    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    6a4636d View commit details
    Browse the repository at this point in the history

  2. Refactor away evaluate handle and friends 

    We needed to everything in this PR in one Go for the code to compile.
    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    eb125e9 View commit details
    Browse the repository at this point in the history

  3. Fix escaping goja from evals into business logic 

    Resolves: #1189 (comment)
    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    548337e View commit details
    Browse the repository at this point in the history

  4. Add type detection to ElementHandle.fill 

    Resolves: #1189 (comment)
    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    02bbe7a View commit details
    Browse the repository at this point in the history

  5. Refactor screenshotter error 

    Co-authored-by: Ankur Agarwal <ankur.agarwal@grafana.com>
    @inancgumus @ankur22
    inancgumus and ankur22 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8b2a59a View commit details
    Browse the repository at this point in the history

  6. Remove test browser goja helpers

    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    848babb View commit details
    Browse the repository at this point in the history

  7. Add test asString helper

    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e239916 View commit details
    Browse the repository at this point in the history

  8. Refactor test helpers to TB

    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7518104 View commit details
    Browse the repository at this point in the history

  9. Refactor test assertions to asBool and asString 

    Co-authored-by: Ankur Agarwal <ankur.agarwal@grafana.com>
    @inancgumus @ankur22
    inancgumus and ankur22 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9e5a472 View commit details
    Browse the repository at this point in the history

  10. Refactor done strings to resultDone 

    Co-authored-by: Ankur Agarwal <ankur.agarwal@grafana.com>
    @inancgumus @ankur22
    inancgumus and ankur22 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a05e8e3 View commit details
    Browse the repository at this point in the history

  11. Add temporary assertions for catching goja values 

    This commit is intentionally failing
    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    0e26184 View commit details
    Browse the repository at this point in the history

  12. Mark failing tests due to goja delivery to execctx 

    These should be fixed.
    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3ed072b View commit details
    Browse the repository at this point in the history