Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goja escape from DispatchEvents #1193

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fix goja escape from DispatchEvents #1193

merged 3 commits into from
Jan 26, 2024

Commits on Jan 25, 2024

  1. Refactor away goja from dispatch event 

    This is a necessary fix to remove passing Goja values to
ExecutionContext.
    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    06d14d1 View commit details
    Browse the repository at this point in the history

  2. Fix TestBrowserOptionsSlowMo dispatch event

    @inancgumus
    inancgumus committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    0a34ed2 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Refactor locator dispatch test to constructor 

    Resolves: https://github.com/grafana/xk6-browser/pull/1193/files#r1466516889
    @inancgumus
    inancgumus committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    eca3338 View commit details
    Browse the repository at this point in the history