Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a localPersister #1197

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Add a localPersister #1197

merged 5 commits into from
Jan 31, 2024

Commits on Jan 31, 2024

  1. Add a local file persister 

    This is the file persister that will be used when testing locally. This
will replace the current implementation that is in screenshotter.
    @ankur22
    ankur22 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5c89130 View commit details
    Browse the repository at this point in the history

  2. Add test for LocalFilePersister

    @ankur22
    ankur22 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ce03d7e View commit details
    Browse the repository at this point in the history

  3. Add an instance of local persister 

    Adding a localPersister will allow access to it from anywhere that has
access to the moduleVU. This change is a temporary refactor and will
need to be changed again once the remotePersister has been implemented
whereby either of the two will be chosen depending on the environment.
    @ankur22
    ankur22 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    6936239 View commit details
    Browse the repository at this point in the history

  4. Refactor to work with the filePersister 

    We're refactoring out the existing use of working directly with the os
package to persist screenshots to the local disk from screenshotter.
This change enables to work with the localPersister whereby the
underlying details of the where and how are hidden allowing us to
easily use either the localPersister (current) or the remotePersister
(future).
    @ankur22
    ankur22 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2747713 View commit details
    Browse the repository at this point in the history

  5. Remove the todo 

    This todo has been moved to the localPersister
    @ankur22
    ankur22 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ab79ae7 View commit details
    Browse the repository at this point in the history