Add nil checks in requestByID #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For unknown reasons mainFrameSession or mainFrameSession.networkManager (it's unknown exactly which one) are nil, which has caused NPDs. We're now adding nil checks here to prevent the NPDs, but we're also logging when these are nil in the hopes that we can identify which component is nil and under what conditions.
We want to capture the warning but not defend against the NPD so that we don't ignore the issue and keep on working on it when more cases arise.
inancgumus
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding
nilchecks inrequestByID.Why?
For unknown reasons
mainFrameSessionormainFrameSession.networkManager(it's unknown exactly which one) arenil, which has caused NPDs. We're addingnilchecks here to prevent the NPDs, but we're now logging to see what components arenilto try and work out what is causing the NPD.Checklist
Related PR(s)/Issue(s)
Updates: #986