De-sobekify the Tap methods and remove panics
#1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll remove option parsing from Tap soon. So, there won't be a need for another `tap` method.
inancgumus
force-pushed
the
degojaify/tap
branch
from
f0e3910
to
61a9f20
Compare
inancgumus
force-pushed
the
degojaify/tap
branch
from
5e9318f
to
446ffc0
Compare
Closed
inancgumus
changed the title
Tap methodsTap methods and remove panics
andrewslotin
approved these changes
Apr 18, 2024
inancgumus
changed the title
Tap methods and remove panicsTap methods and remove panics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Degojaifies the
Tapmethods.Why?
See: #1064 and #1251.
Checklist
Related PR(s)/Issue(s)
Updates #1251 and #1064.