Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lint workflow #1297

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Update lint workflow #1297

wants to merge 8 commits into from
+68 −72

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented May 2, 2024

What?

Why?

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@ankur22
Move the linter-settings
fb8def2 
This makes it easier to compare the k6 linter file
@ankur22
Add the forbidigo from k6 linter file
69679b0 
This adds rules to forbid fmt.Print calls, most os usages and syscalls.
@ankur22 ankur22 marked this pull request as draft May 2, 2024 17:54
@ankur22
Use k6 linter job template
87c7aba
@ankur22
Use linter and dep only
145dfd0
@ankur22
Use k6 lint
416fef4 
Copy the lint file but add only-new-issues: true to see the outcome.
@ankur22
Add k6 actions and lint workflow
bf01b7e 
Copy the actions and lint workflow. The action has been amended to add
only-new-issues: true.
@ankur22
Use k6 linter again
91f61d8
@ankur22
Use the k6 CI template
17e66f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ankur22