Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page.goto tests for async #1316

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix page.goto tests for async #1316

merged 1 commit into from
May 8, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus self-assigned this May 8, 2024
@inancgumus inancgumus requested a review from ankur22 May 8, 2024 11:56
@inancgumus inancgumus added tests async supports async (promises) bug Something isn't working labels May 8, 2024
ankur22
ankur22 approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced May 8, 2024
Closed
Closed
@inancgumus inancgumus merged commit f096a21 into main-async May 8, 2024
14 checks passed
@inancgumus inancgumus deleted the async/fix-page-goto-tests branch May 8, 2024 12:00
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
async supports async (promises) bug Something isn't working tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22