Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mouse #1318

Merged
merged 3 commits into from
May 9, 2024
Merged

Fix mouse #1318

merged 3 commits into from
May 9, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented May 9, 2024 •
edited
Loading

What?

See #1317

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

@inancgumus
Fix mouse
b403826 
- Mouse up shouldn't take coordinates.
- Mouse down shouldn't take coordinates.
- Mouse move should work.
@inancgumus
Add mouse test
edfbf6a
@inancgumus inancgumus added bug Something isn't working breaking PRs that need to be mentioned in the breaking changes section of the release notes labels May 9, 2024
@inancgumus inancgumus self-assigned this May 9, 2024
@inancgumus inancgumus requested a review from ankur22 May 9, 2024 08:39
@inancgumus inancgumus marked this pull request as ready for review May 9, 2024 08:39
@inancgumus inancgumus mentioned this pull request May 9, 2024
Closed
ankur22
ankur22 previously approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think the dblclick test needs to be amended though.

tests/mouse_test.go Show resolved Hide resolved
@inancgumus inancgumus requested a review from ankur22 May 9, 2024 09:52
ankur22
ankur22 approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus merged commit 88e71c4 into main May 9, 2024
17 checks passed
@inancgumus inancgumus deleted the fix/mouse branch May 9, 2024 10:18
@inancgumus inancgumus mentioned this pull request May 21, 2024
Merged
7 tasks
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
breaking PRs that need to be mentioned in the breaking changes section of the release notes bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22