Fix navigate to link in new page #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have identified that the call to RunIfWaitingForDebugger wasn't being performed at the correct time when a new page was created after a link was clicked on that opened the page. The first step is to move out of the initOptions so that we can eventually run it independently of the other setup/init steps.
ankur22
force-pushed
the
fix/827-link-new-window
branch
from
dbe0a49
to
1d00ce3
Compare
ankur22
force-pushed
the
fix/827-link-new-window
branch
from
1d00ce3
to
cde4f4f
Compare
ankur22
changed the title
inancgumus
reviewed
May 15, 2024
inancgumus
approved these changes
May 15, 2024
This test ensures that a new page is opened and correctly navigated to when a link with target=_blank is clicked on.
Instead of basing the test on waiting a certain time and retrying every so often, we're now working with the built in APIs that help with this wait action in a more stable manner.
ankur22
force-pushed
the
fix/827-link-new-window
branch
from
6ed6d20
to
56dc610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move the CDP request
RunIfWaitingForDebuggerto be called first when creating aFrameSession.Why?
We have identified that the call to
RunIfWaitingForDebuggerwasn't being performed at the correct time when a new page was created after a link was clicked on that opened the page.This is currently the simplest and safest solution. I tried to place some of the CDP actions that are in
NewFrameSessionwithin their own goroutines but there were data races.Checklist
Related PR(s)/Issue(s)
Updates: #827