Fix iframe panic on navigation #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handleFrameTree is called when a new frame session is created for a new frame that is attached. Some of these frames are not mainframes but do contains a tree structures with child frames. If we don't handle the frame tree for these non-mainframes, this will prevent navigations from being handled for these frames and a panic/error which would stop the test iteration.
The only reason we have initialFrame flag is to use in logging, so it's not an important thing to factor in for the runtime, but it may help in debugging issues. Rather than remove it, I've changed it so any mainframe is regarded as the initialFrame.
The change prevents the iframe child frames from being removed when a detach event comes in from Chrome. An iframe seems to be associated to multiple sessions. The initial sessions that is linked to the mainframe that the iframe belongs to and its own session. When the page navigates, a detach event arrives with the initial session and a swap type for the iframe. The iframe though is associated to its own session. In this scenario we want to avoid removing frames, which prevents panics occurring when the iframe navigates.
ankur22
force-pushed
the
fix/1341-iframe-detach
branch
from
e5f8098
to
0a6d3bf
Compare
inancgumus
approved these changes
May 24, 2024
I'm working on the test, but it's difficult one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes an issue where a page with an iframe panics during a navigation.
Why?
The reason are two fold:
Checklist
Related PR(s)/Issue(s)
Updates: #1341