Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor request to act more like JS #1349

Merged
merged 2 commits into from
May 28, 2024
Merged

Refactor request to act more like JS #1349

merged 2 commits into from
May 28, 2024

Commits on May 28, 2024

  1. Refactor postData to return nil 

    If the postData is an empty string, return a nil instead which better
aligns with JS.
    @ankur22
    ankur22 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2802366 View commit details
    Browse the repository at this point in the history

  2. Refactor request.postDataBuffer 

    When the buffer is empty return a nil, which is how js apis work.
    @ankur22
    ankur22 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0684981 View commit details
    Browse the repository at this point in the history