Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Response #1364

Merged
merged 8 commits into from
Jun 5, 2024
Merged

Async Response #1364

merged 8 commits into from
Jun 5, 2024

Conversation

inancgumus
Copy link
Member

What?

  • Turns panics into errors for Response.
  • Turns Response mapping into async.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1309

@inancgumus inancgumus added refactor async supports async (promises) mapping k6 browser to Goja mapping related. stability runtime stability improvements labels Jun 3, 2024
@inancgumus inancgumus self-assigned this Jun 3, 2024
@inancgumus inancgumus mentioned this pull request Jun 3, 2024
Closed
@inancgumus inancgumus marked this pull request as ready for review June 3, 2024 08:40
@inancgumus inancgumus requested a review from ankur22 June 3, 2024 08:40
ankur22
ankur22 reviewed Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I think a couple of APIs need to be reviewed again though as they've promisified, but they shouldn't have been.

browser/response_mapping.go Outdated Show resolved Hide resolved
browser/response_mapping.go Outdated Show resolved Hide resolved
browser/response_mapping.go Show resolved Hide resolved
browser/response_mapping.go Show resolved Hide resolved
@inancgumus
Copy link
Member Author

Generally looks good. I think a couple of APIs need to be reviewed again though as they've promisified, but they shouldn't have been.

Thanks. I’ve rechecked this against PW. There is only one issue: headers and headersAll promisification should switch. The rest are fine.

@inancgumus inancgumus requested a review from ankur22 June 3, 2024 17:18
@inancgumus inancgumus changed the base branch from main-async to fix/async/examples June 4, 2024 14:10
Base automatically changed from fix/async/examples to main-async June 4, 2024 14:24
ankur22
ankur22 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus merged commit 4c8aaf8 into main-async Jun 5, 2024
14 checks passed
@inancgumus inancgumus deleted the async/response branch June 5, 2024 07:54
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
async supports async (promises) mapping k6 browser to Goja mapping related. refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22