Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async JSHandle #1366

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Async JSHandle #1366

merged 7 commits into from
Jun 5, 2024

Conversation

inancgumus
Copy link
Member

What?

#1303

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

@inancgumus inancgumus self-assigned this Jun 4, 2024
@inancgumus inancgumus marked this pull request as ready for review June 4, 2024 09:41
@inancgumus inancgumus added async supports async (promises) mapping k6 browser to Goja mapping related. labels Jun 4, 2024
@inancgumus inancgumus mentioned this pull request Jun 4, 2024
Closed
@inancgumus inancgumus requested a review from ankur22 June 4, 2024 09:43
@inancgumus inancgumus force-pushed the async/js-handle branch 2 times, most recently from 8f6bb8d to 8acfd54 Compare June 4, 2024 14:41
ankur22
ankur22 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Base automatically changed from async/js-handle-prepare to main-async June 5, 2024 07:57
@inancgumus inancgumus merged commit ac79cdc into main-async Jun 5, 2024
13 checks passed
@inancgumus inancgumus deleted the async/js-handle branch June 5, 2024 07:58
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
async supports async (promises) mapping k6 browser to Goja mapping related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22