Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPD in getOwnerFrame #1435

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix NPD in getOwnerFrame #1435

merged 1 commit into from
Sep 23, 2024

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Sep 20, 2024 •
edited
Loading

What?

Checking for nil after calling dom.DescribeNode().

Why?

The node from dom.DescribeNode() can be nil, so checking for nil before proceeding.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #1416

@ankur22
Fix NPD in getOwnerFrame
65b0470 
The node from dom.DescribeNode() can be nil, so checking for nil before
proceeding.
@ankur22 ankur22 mentioned this pull request Sep 20, 2024
Closed
@ankur22 ankur22 merged commit c9fa346 into main Sep 23, 2024
23 checks passed
@ankur22 ankur22 deleted the fix/npd-getOwnerFrame branch September 23, 2024 09:15
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankur22 @inancgumus