Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging close browser cdp req #1442

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Fix hanging close browser cdp req #1442

merged 7 commits into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. Refactor to use existing background context 

    Use the existing background context instead of creating a new one.
    @ankur22
    ankur22 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    aa261ce View commit details
    Browse the repository at this point in the history

  2. Refactor to use the existing background context 

    Use the existing background context instead of creating a new one.
    @ankur22
    ankur22 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0f14a6c View commit details
    Browse the repository at this point in the history

  3. Refactor to work with a timeout on cdp close req 

    Since the context that is used is a essentially a background context,
we need to have a timeout in place. There is a chance that the browser
process has already exited but the connection thinks it is still alive.
By using the timeout we're ensuring that the iteration can end, which
allows for the events to be emitted by the k6 event system and so allow
k6 to exit in a timely manner.
    @ankur22
    ankur22 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6f62444 View commit details
    Browse the repository at this point in the history

  4. Refactor to use timed context in send 

    Working with c.ctx will essentially never end since it is basically a
background context. Using the passed in context which has a timeout
will help ensure the send goroutine ends quickly.
    @ankur22
    ankur22 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e70422f View commit details
    Browse the repository at this point in the history

  5. Fix lint issue nlreturn

    @ankur22
    ankur22 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a472330 View commit details
    Browse the repository at this point in the history

  6. Update k6 with the k6 event system fix 

    The PR we're interested in is grafana/k6#3968.
    @ankur22
    ankur22 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b2bd13c View commit details
    Browse the repository at this point in the history

  7. Update github action go versions

    @ankur22
    ankur22 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b4b16ba View commit details
    Browse the repository at this point in the history