Update cdp dependency #1447
Draft
Update cdp dependency #1447
+32
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
commented
Sep 27, 2024
| @@ -104,13 +105,30 @@ func NewRequest(ctx context.Context, rp NewRequestParams) (*Request, error) { | |||
| isNavigationRequest := string(ev.RequestID) == string(ev.LoaderID) && | |||
| ev.Type == network.ResourceTypeDocument | |||
|
|
|||
| var pd string | |||
| for _, i := range ev.Request.PostDataEntries { | |||
There was a problem hiding this comment.
At the moment this is the most obvious breaking change.
I'm not sure why the post data is broken into a slice like this. It would be good to get to the bottom of why it's done this way so that we know how to handle the entries.
ankur22
commented
Sep 27, 2024
| pd += string(decodedBytes) | ||
| } | ||
|
|
||
| fmt.Println(pd) |
There was a problem hiding this comment.
I've left this is to easily debug the response body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update cdp dependency.
Why?
We're working with a 2 year old CDP dependency library. Updating to the latest one to ensure that we don't miss any new fixes, features etc.
Checklist
Related PR(s)/Issue(s)
Updates: #1430