Refactor if to make it easier to read #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
requested review from
inancgumus and
olegbespalov
and removed request for
a team
inancgumus
approved these changes
Nov 15, 2024
olegbespalov
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
👍 But, same as @inancgumus said, it's weird that tests failing 😢
(A || B) == (!A && !B)
ankur22
force-pushed
the
refactor/frameNavigated
branch
from
93ba678
to
c38371d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Making it simpler to read the if in
frameNavigatedwhich always confuses me. Using De Morgan's Law,(A || B) == (!A && !B).Why?
Make it easier to read.
Checklist
Related PR(s)/Issue(s)