Map [Page|Frame].WaitForNavigation and fix tests #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
add/706-map-waitfornav
branch
from
8ef6c29
to
2677496
Compare
This moves the promise handling to the mapping layer. Lifecycle test are still using promises since its logic is complex to figure out for now. We should refactor them when we finish.
inancgumus
force-pushed
the
add/706-map-waitfornav
branch
from
2677496
to
70ade11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the promise handling for [Page|Frame].WaitForNavigation to the mapping layer. The lifecycle tests are still using promises since its logic is complex to figure out for now. We should refactor them when we finish—I've added a task on #683.
Related: #683
Closes: #706