Remove await method from testBrowser #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
approved these changes
Jan 23, 2023
8 tasks
ankur22
force-pushed
the
refactor/remove-testbrowser-await
branch
from
865d9bc
to
5651d1a
Compare
Now that promises have been moved to a level above the business logic, we can remove the need to run things in promises and assume (in most cases) that things will run synchronously. Where there's still a need to run things in parallel we can use the run method on testBrowser.
ankur22
force-pushed
the
refactor/remove-testbrowser-await
branch
from
5651d1a
to
9ab2316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that promises have been moved to a level above the business logic, we can remove the need to run things in promises and assume (in most cases) that things will run synchronously. Where there's still a need to run things in parallel we can use the run method on testBrowser.
Updates #683.