Update nil session log warn to debug in page attach #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
approved these changes
Apr 6, 2023
ka3de
approved these changes
Apr 6, 2023
inancgumus
changed the title
Rationale: I suggested this earlier on to detect nil sessions. But now, this warning is outdated because when users running multiple instance/VU tests, they will see dozens/hundreds lines of warnings. The core reason we receive a lot of these warnings is: We need to correctly handle the CDP messages while sending and receiving them (the order of them). #848
inancgumus
force-pushed
the
update/onAttachedToTarget-nil-session-info
branch
from
c1df715
to
a53665c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggested this earlier on to detect nil sessions. But now, this warning is outdated because when users running multiple instance/VU tests, they will see dozens/hundreds lines of warnings.
The core reason we receive a lot of these warnings is:
We need to correctly handle the CDP messages while sending and receiving them (the order of them).
#848