Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for browser env option #870

Merged
merged 3 commits into from
May 3, 2023
Merged

Conversation

ka3de
Copy link
Collaborator

@ka3de ka3de commented May 3, 2023

A decision was made to no longer support the env browser option as this was not providing much value.

Closes #869.

A decision was made to no longer support the env browser option as this
was not providing much value.
@ka3de ka3de self-assigned this May 3, 2023
Fixes the associated linter issue.
@ka3de ka3de marked this pull request as ready for review May 3, 2023 12:21
@ka3de ka3de requested a review from ankur22 May 3, 2023 12:21
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 Really happy to see that unused ctxCancel go 🙂

@ka3de ka3de merged commit af0f9f0 into main May 3, 2023
@ka3de ka3de deleted the remove/869-browser-env-opt branch May 3, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove browser env option
2 participants