Refactor registry back into browser package #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rename better reflects what the package does, which is the entry point when k6 calls the browser module to start working with it. It will also be used to initialise test wide resources such as the pid and ws url registries.
We're moving the pid registry back into module. It makes more sense for the pid registry to live in the same package as module since it is only used in this package.
We're moving the remote registry back into the module package since it is only ever used there.
k6 depends on the import to be browser and not module.
ankur22
force-pushed
the
refactor/module-registry
branch
from
5468478
to
619acc0
Compare
This no longer stutters.
ankur22
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The
browserpackage doesn't quite reflect what is does, so initially the change was made to rename it tomodule. This affects the import in k6. For now it's a lot simpler to just keep it asbrowser.It also makes more sense to have the registry types close to where they're being used, which is in the
browserpackage, sopidRegistryandremoteRegistryhave been moved back into a newregistry.gofile in thebrowserpackage.Changes based on: #899 (review)
Checklist
Tasks