Remove some of the http metrics #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this came from analysing and working on removing the web vital rating metrics. It became apparent that we didn't need to expose all these http metrics just yet and instead should focus on the ones that are most used. We used k6 for guidance on this and they have suggested that browser_http_req_duration and browser_http_req_failed are the most useful. We can add metrics back in when users show interest in them. This will for now also reduce the overall number of time series metrics.
ankur22
added
the
breaking
ka3de
approved these changes
May 31, 2023
inancgumus
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The motivation for this came from analysing and working on removing the web vital rating metrics. It became apparent that we didn't need to expose all these http metrics just yet and instead should focus on the ones that are most used. We used k6 for guidance on this and they have suggested that
browser_http_req_durationandbrowser_http_req_failedare the most useful. We can add metrics back in when users show interest in them. This will also reduce the overall number of time series metrics.Testing
When you run any of the example test scripts, you should find that we now only display
browser_http_req_durationandbrowser_http_req_failedhttpbased metrics:browser_http_req_duration.....: avg=216.97ms min=102.97ms med=208.59ms max=339.36ms p(90)=313.21ms p(95)=326.28ms browser_http_req_failed.......: 0.00% ✓ 0 ✗ 3Please describe your pull request
Checklist
Tasks