Do not expose browser.on() #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A decision was made to no longer expose browser.on method as it currently only supports 'disconnect' event, and that is non applicable after the changes made to abstract the browser initialization/closing procedures from the JS API in #910.
inancgumus
approved these changes
Jun 2, 2023
8 tasks
ankur22
added a commit
to grafana/k6-DefinitelyTyped
that referenced
this pull request
Jun 30, 2023
This has been removed from the browser module. See grafana/xk6-browser#919 for more details.
typescript-bot
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Aug 3, 2023
* Refactor browserContext into its own file * Add type definition for browser * Add type definition for browserContext * Apply suggestions from code review Co-authored-by: ka3de <danijs12@hotmail.com> * Remove browser.on from k6 browser module This has been removed from the browser module. See grafana/xk6-browser#919 for more details. * Move all k6 browser module definitions into one There's an issue with importing the type definitions for the k6 browser module where the actual definitions aren't displaying but the types can be imported whereby the IDE recognises the types. We've found that by moving them into a single file helps resolves this issue. --------- Co-authored-by: ka3de <danijs12@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Considering the API changes made in #910, for which the browser initialization/closing procedures are no longer delegated/exposed to the end user, but instead are automatically handled by k6 browser implementation from the Go layer, currently the
browser.on()method is not providing any value as we are only supporting thedisconnectevent.Therefor, a decision is made to not expose this method by now, until more events types are supported.
Closes #913 .
Optional tasks
Tasks