Remove goroutine ID field from logger #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the goroutine ID as a log field required copying the calling goroutine stack into a buffer and parsing the ID from it. This was done for each log action which is very inefficient and does not provide much value as we are already using a field for the iteration ID. Therefore our decision is to remove it completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding the goroutine ID as a log field required copying the calling goroutine stack into a buffer and parsing the ID from it. This was done for each log action which is very inefficient and does not provide much value as we are already using a field for the iteration ID which allows us to correlate logs. Therefore our decision is to remove it completely.