Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-namespaced resource for namespaces #76

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

pablochacin
Copy link
Contributor

Using a namespaced resource interface for accessing namespaces (in particular, creating or deleting) fails because the namespace resource is non-namespaced.

This change set introduces logic for handling namespaces as a special resource type and use a non-namespaced resource interface.

Fixes #75

Signed-off-by: Pablo Chacin pablochacin@gmail.com

@pablochacin pablochacin marked this pull request as draft October 12, 2022 16:47
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin marked this pull request as ready for review October 12, 2022 16:52
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that I was able to use the Resource API to create, list, and delete a namespace. Please correct the noted typo.

pkg/resources/resources.go Outdated Show resolved Hide resolved
Co-authored-by: Paul Balogh <javaducky@gmail.com>
@javaducky javaducky merged commit ef470d4 into grafana:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting namespace using the generic interface fails
2 participants