Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Active Directory authentication for Microsoft SQL Server #55

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Support Azure Active Directory authentication for Microsoft SQL Server #55

merged 2 commits into from
Feb 14, 2024

Conversation

JBodkin-Amphora
Copy link
Contributor

@JBodkin-Amphora JBodkin-Amphora commented Jan 24, 2024

Connecting to Microsoft SQL Server on Azure using Microssoft Entra ID (Azure Active Directory) requires a different driver name (azuresql) to be passed in as a parameter as the sqlserver driver does not provide an implementation to obtain tokens.

I note that the README mentions that this project is not accepting support for additional SQL implementions, but I was wondering if this might be an exception as it introduces a different authentication method for the same dialect.

@JBodkin-Amphora JBodkin-Amphora requested a review from a team as a code owner January 24, 2024 14:40
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

@andrewslotin andrewslotin requested review from pablochacin and removed request for a team February 13, 2024 11:10
@pablochacin
Copy link
Contributor

@JBodkin-Amphora Thanks for your contribution. Based on this errors when building the extension after the changes in this PE, It looks like the PR is missing the updated go.mod and go.sum files:

Error: C:\Users\runneradmin\go\pkg\mod\github.com\microsoft\go-mssqldb@v1.6.0\azuread\configuration.go:13:2: github.com/Azure/azure-sdk-for-go/sdk/azcore@v1.7.1: missing go.sum entry for go.mod file; to add it:
	go mod download github.com/Azure/azure-sdk-for-go/sdk/azcore
Error: C:\Users\runneradmin\go\pkg\mod\github.com\microsoft\go-mssqldb@v1.6.0\azuread\configuration.go:14:2: github.com/Azure/azure-sdk-for-go/sdk/azcore@v1.7.1: missing go.sum entry for go.mod file; to add it:
	go mod download github.com/Azure/azure-sdk-for-go/sdk/azcore
Error: C:\Users\runneradmin\go\pkg\mod\github.com\microsoft\go-mssqldb@v1.6.0\azuread\configuration.go:15:2: github.com/Azure/azure-sdk-for-go/sdk/azcore@v1.7.1: missing go.sum entry for go.mod file; to add it:
	go mod download github.com/Azure/azure-sdk-for-go/sdk/azcore
Error: C:\Users\runneradmin\go\pkg\mod\github.com\microsoft\go-mssqldb@v1.6.0\azuread\configuration.go:16:2: github.com/Azure/azure-sdk-for-go/sdk/azidentity@v1.3.0: missing go.sum entry for go.mod file; to add it:
	go mod download github.com/Azure/azure-sdk-for-go/sdk/azidentity

@JBodkin-Amphora
Copy link
Contributor Author

@pablochacin I've updated the pull request to include the go module checksums, please could you trigger the CI workflows again?

Copy link
Contributor

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablochacin pablochacin merged commit 408096e into grafana:master Feb 14, 2024
8 checks passed
@JBodkin-Amphora JBodkin-Amphora deleted the patch-1 branch February 15, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants