Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding clickhouse support in k6. #58

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Adding clickhouse support in k6. #58

merged 2 commits into from
Apr 15, 2024

Conversation

samof76
Copy link
Contributor

@samof76 samof76 commented Mar 14, 2024

No description provided.

@samof76 samof76 requested a review from a team as a code owner March 14, 2024 14:16
@samof76 samof76 requested review from pablochacin and removed request for a team March 14, 2024 14:16
@CLAassistant
Copy link

CLAassistant commented Mar 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@szkiba
Copy link
Contributor

szkiba commented Mar 14, 2024

Hey @samof76 , as I see you forgot to add github.com/ClickHouse/clickhouse-go/v2 dependency to go.mod ....

@samof76
Copy link
Contributor Author

samof76 commented Mar 15, 2024

Hey @samof76 , as I see you forgot to add github.com/ClickHouse/clickhouse-go/v2 dependency to go.mod ....

Yeah. Forgot to commit. Done now.

@pablochacin pablochacin merged commit fe5fbf5 into grafana:master Apr 15, 2024
1 check passed
@200Puls 200Puls mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablochacin pablochacin pablochacin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samof76 @CLAassistant @szkiba @pablochacin