feat: allow name tag, and overwrite url tag with name tag if set #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkadirtan
requested review from
oleiade and
olegbespalov
and removed request for
a team
|
|
…th url and name tags.
|
bump @oleiade @olegbespalov |
olegbespalov
approved these changes
Feb 19, 2024
No problem, thanks for the review. What is the merge process? Do we need another review, apparently I can't merge. |
Yes, we do allow the merge only from maintainers. Once the @oleiade (as the remaining reviewer) reviews and approves the changes, it could be possible. Later, we will issue the tag (or bump an updated version of the module to the k6 core. |
|
The k6's PR for the reference grafana/k6#3606 |
NikolaiNikolaevichBoyko
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR allows users to manually set name tag. Also, when name tag is present, it will overwrite the url tag.
Why?
Query parameters in the url, cause too many trends to appear in metrics. This is explained in the issue as well.
Checklist
make lint) and all checks pass.make test) and all tests pass.Related PR(s)/Issue(s)
Spiritual equivelant in k6 repo: grafana/k6#2703
Closes #33