Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing undefined/null handler #73

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jun 7, 2024

What?

Fixes passing undefined/null handler to the addEventListener

Why?

We should not panic.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov added the bug Something isn't working label Jun 7, 2024
@olegbespalov olegbespalov self-assigned this Jun 7, 2024
@olegbespalov olegbespalov requested a review from a team as a code owner June 7, 2024 10:48
@olegbespalov olegbespalov requested review from oleiade and codebien and removed request for a team June 7, 2024 10:48
@mstoykov mstoykov merged commit 113a951 into main Jun 7, 2024
10 checks passed
@mstoykov mstoykov deleted the fix/on-undefined-handler branch June 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants