Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CommonJS build #603

Closed
jonkoops opened this issue Oct 29, 2023 · 0 comments · Fixed by #607
Closed

Remove CommonJS build #603

jonkoops opened this issue Oct 29, 2023 · 0 comments · Fixed by #607
Labels
breaking Issues or PRs that contain breaking changes type/feat

Comments

@jonkoops
Copy link
Collaborator

What

Currently the package includes both a CommonJS and JavaScript module version. Now that Node.js supports JavaScript modules, it should no longer be necessary to include a CommonJS version, making this a Pure ESM package.

Why

  • Node.js now supports JavaScript modules
  • It will reduce the size of the package
  • It will reduce the amount of issues with dual packaging

How

Remove all CommonJS related code.
@jonkoops jonkoops added breaking Issues or PRs that contain breaking changes type/feat labels Oct 29, 2023
@jonkoops jonkoops mentioned this issue Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Issues or PRs that contain breaking changes type/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: remove support for CommonJS jonkoops/graphql-request
1 participant
@jonkoops