Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove support for CommonJS #607

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat!: remove support for CommonJS #607

merged 1 commit into from
Oct 30, 2023

Conversation

jonkoops
Copy link
Collaborator

Drops the CommonJS distribution in favor of going for a pure ESM package. This also removes the main and types fields, opting to only support the exports field.

Closes #603
Closes #532

@jonkoops jonkoops added the breaking Issues or PRs that contain breaking changes label Oct 29, 2023
@jonkoops jonkoops requested a review from jasonkuhrt October 29, 2023 16:27
jasonkuhrt
jasonkuhrt approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonkoops jonkoops merged commit c3a309f into graffle-js:main Oct 30, 2023
6 of 7 checks passed
@jonkoops jonkoops deleted the drop-commonjs branch October 30, 2023 14:56
@TomChv TomChv mentioned this pull request Jun 14, 2024
Merged
@TomChv TomChv mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonkuhrt jasonkuhrt jasonkuhrt approved these changes

Assignees
No one assigned
Labels
breaking Issues or PRs that contain breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CommonJS build Remove main field of package.json in future
2 participants
@jonkoops @jasonkuhrt