feat(generator): separate name and namespace name config #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkuhrt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for the client name to be controlled without affecting the generated client interface (exports).
This helps with our documentation tooling wherein we want to have examples import like
import { Graffle } from './graffle/__.js'as if we are using the default, but meanwhile the source code for those examples lives in a codebase with multiple schemas so its name cannot be"default". Now, the interface stays the same but in the source code the name is"pokemone"while in the website it is"default"but in both cases the interface is the same, the names are only affecting how the generated client types are looked up which is self-contained.