feat!: add spec compliant default Accept header
#618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
commented
Nov 6, 2023
| @@ -62,65 +61,6 @@ test(`minimal raw query with response headers`, async () => { | |||
| expect(headers.get(`X-Custom-Header`)).toEqual(reqHeaders![`X-Custom-Header`]) | |||
| }) | |||
|
|
|||
| test(`minimal raw query with response headers and new graphql content type`, async () => { | |||
There was a problem hiding this comment.
This test is no longer relevant as this mime-type is no longer spec compliant.
jonkoops
commented
Nov 6, 2023
| expect(result).toEqual({ ...body, status: 200 }) | ||
| }) | ||
|
|
||
| test(`minimal raw query with response headers and application/graphql-response+json response type`, async () => { |
There was a problem hiding this comment.
We no longer need this test as this header is now sent by default. Also this wrongly set the Content-Type header, whereas the content-type should always be application/json.
jonkoops
commented
Nov 6, 2023
| expect(result).toEqual({ ...body, status: 200 }) | ||
| }) | ||
|
|
||
| test(`content-type with charset`, async () => { |
There was a problem hiding this comment.
This test was not doing anything, the relevant code was already commented out.
jonkoops
commented
Nov 6, 2023
| @@ -336,31 +276,6 @@ test.skip(`extra fetch options`, async () => { | |||
| `) | |||
| }) | |||
|
|
|||
| test(`case-insensitive content-type header for custom fetch`, async () => { | |||
There was a problem hiding this comment.
This was testing internal behavior of Headers, so this should no longer be needed.
jonkoops
commented
Nov 6, 2023
| @@ -107,24 +107,6 @@ describe(`using class`, () => { | |||
| expect(mock.requests[0]?.headers[`x-foo`]).toEqual(`new`) | |||
| }) | |||
| }) | |||
|
|
|||
| describe(`allows content-type header to be overwritten`, () => { | |||
There was a problem hiding this comment.
This test was moved into the main suite.
jonkoops
force-pushed
the
add-accept-header
branch
from
704d636 to
c4bb3a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
Acceptheader to all requests with a spec-compliant mime-type. This PR also does some code cleanup and removes support for the legacyapplication/graphql+jsonmime type.Closes #140